boards: shields: Use new naming scheme for shield node labels #50526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwango
force-pushed
the
dev_shields_nodelabel
branch
from
4623935 to
9bc72f5
Compare
MaureenHelm
requested changes
Sep 23, 2022
erwango
force-pushed
the
dev_shields_nodelabel
branch
from
9bc72f5 to
c9e4492
Compare
Update requirements regarding board connectors compatibility now that dtc versions prior to 1.4.2 can't be used anymore (current required version is 1.4.6). Signed-off-by: Erwan Gouriou <[email protected]>
In order to avoid device definitions conflicts when compiling shields description with boards embedding similar devices, nodelabels of devices in shield's devicetree file should differ from the nodelabels used in board's devicetree file. The form to be used was discussed in zephyrproject-rtos#50040 and agreed to be as <device>_<shield_name>. Update shields documentation to make it an explicit rule. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
dev_shields_nodelabel
branch
from
c9e4492 to
5e0ecfa
Compare
jfischer-no
previously approved these changes
Sep 26, 2022
nandojve
requested changes
Sep 26, 2022
Update existing shields to conform with new node label naming scheme. Signed-off-by: Erwan Gouriou <[email protected]>
Fix indentation issues in shield overlays seen when reviewing previous commit. Signed-off-by: Erwan Gouriou <[email protected]>
erwango
force-pushed
the
dev_shields_nodelabel
branch
from
5e0ecfa to
3f2e577
Compare
MaureenHelm
approved these changes
Sep 26, 2022
nandojve
approved these changes
Sep 26, 2022
jfischer-no
approved these changes
Sep 27, 2022
gmarull
approved these changes
Sep 27, 2022
Nicolas62x
added a commit
to Nicolas62x/zephyr_stm32mp1
that referenced
this pull request
Jun 20, 2023
Replaced incorrect names with correct ones. Fixes: zephyrproject-rtos#50526 Signed-off-by: Nicolas Granger <[email protected]>
fabiobaltieri
pushed a commit
that referenced
this pull request
Jun 20, 2023
Replaced incorrect names with correct ones. Fixes: #50526 Signed-off-by: Nicolas Granger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #50040
Note: We end up with quite non nice labels like:
dac80508_dac80508_evmuc8176_waveshare_epaper_gdew042t2lsm303agr-magn_x_nucleo_iks01a2I wonder if
<shield_name>_<device>instead of<device>_<shield_name>wouldn't be a better option. Toughs ?